https://bugs.llvm.org/show_bug.cgi?id=42973

            Bug ID: 42973
           Summary: [WebAssembly] SIMD bit-shifts can remove unroll thanks
                    to V8 fixes
           Product: new-bugs
           Version: trunk
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P
         Component: new bugs
          Assignee: unassignedb...@nondot.org
          Reporter: bvib...@wikimedia.org
                CC: htmldevelo...@gmail.com, llvm-bugs@lists.llvm.org

Created attachment 22370
  --> https://bugs.llvm.org/attachment.cgi?id=22370&action=edit
Patch that removes this

This bit in WebAssemblyTargetLowering::LowerShift

-  // Expand all vector shifts until V8 fixes its implementation
-  // TODO: remove this once V8 is fixed
-  if (!Subtarget->hasUnimplementedSIMD128())
-    return unrollVectorShift(Op, DAG);

can be removed since https://chromium-review.googlesource.com/c/v8/v8/+/1722198
fixed non-constant SIMD bit-shifts.

This gives me a speedup of several percent in dav1d AV1 decoder on my
WebAssembly SIMD branch running in Chrome Canary.

Attached patch reapplies https://reviews.llvm.org/D58800 which was accidentally
merged early a few months ago, then reverted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to