https://bugs.llvm.org/show_bug.cgi?id=37317
Bug ID: 37317
Summary: ModuleList::FindGlobalVariables fails with
append=false
Product: lldb
Version: unspecified
Hardware: PC
OS: Linux
Status: NEW
Severity: enhancement
Priority: P
Component: All Bugs
Assignee: lldb-...@lists.llvm.org
Reporter: t...@tromey.com
CC: llvm-bugs@lists.llvm.org
In my Rust work I found that ModuleList::FindGlobalVariables will not
work properly when passed append=false.
The issue comes because SymbolFileDWARF::FindGlobalVariables does:
// If we aren't appending the results to this list, then clear the list
if (!append)
variables.Clear();
So, if there are multiple modules, later ones will erase the results
from earlier ones.
A simple fix would be to change ModuleList::FindGlobalVariables to
do something like:
if (!append) variables.Clear();
...
(*pos)->FindGlobalVariables(name, nullptr, true, max_matches,
variable_list);
That is, always pass append=true to the callees.
I would submit a patch for this but I don't know how to write a test case.
So, I thought I'd file this instead. I'm also going to fix it in my tree.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
