https://llvm.org/bugs/show_bug.cgi?id=31414

            Bug ID: 31414
           Summary: tools/clang/lib/Format/Format.cpp:1548: suspicious
                    code ?
           Product: new-bugs
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P
         Component: new bugs
          Assignee: unassignedb...@nondot.org
          Reporter: dcb...@hotmail.com
                CC: llvm-bugs@lists.llvm.org
    Classification: Unclassified

llvm/tools/clang/lib/Format/Format.cpp:1548:23: warning: en
um constant in boolean context [-Wint-in-bool-context]

Source code is

  bool Matched = Tok.is(tok::hash) && !Lex.LexFromRawLexer(Tok) &&
                 Tok.is(tok::raw_identifier) &&
                 Tok.getRawIdentifier() == Name && !Lex.LexFromRawLexer(Tok) &&
                 tok::raw_identifier;

The final expression looks odd to me. Maybe better code

  bool Matched = Tok.is(tok::hash) && !Lex.LexFromRawLexer(Tok) &&
                 Tok.is(tok::raw_identifier) &&
                 Tok.getRawIdentifier() == Name && !Lex.LexFromRawLexer(Tok) &&
                 Tok.is(tok::raw_identifier);

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to