https://llvm.org/bugs/show_bug.cgi?id=28627
Bug ID: 28627
Summary: The function [ getSystemRegistryString ] in [
clang\lib\Driver\MSVCToolChain.cpp ] call
readFullStringValue not properly.
Product: clang
Version: trunk
Hardware: PC
OS: Windows NT
Status: NEW
Severity: normal
Priority: P
Component: Driver
Assignee: unassignedclangb...@nondot.org
Reporter: wuzili1...@163.com
CC: llvm-bugs@lists.llvm.org
Classification: Unclassified
===============clang\lib\Driver\MSVCToolChain.cpp==============
static bool getSystemRegistryString(const char *keyPath, const char *valueName,
std::string &value, std::string *phValue) {
......
......
......
......
lResult = readFullStringValue(hKey, valueName, value);
if (lResult == ERROR_SUCCESS) {
......
......
......
}
lResult = readFullStringValue(hKey, valueName, value);
if (lResult == ERROR_SUCCESS)
......
......
......
}
return false;
#endif // USE_WIN32
}
==============================end=============================
see above, at version 275882, when the function [readFullStringValue] return
true, it means success, but the function [ getSystemRegistryString ] treat true
as failed, because it is expecting 0(ERROR_SUCCESS).
maybe can change to:
lResult = !readFullStringValue(hKey, valueName, value);
hope to fix it.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
