https://llvm.org/bugs/show_bug.cgi?id=26639
Bug ID: 26639
Summary: ControlFlowIntegrity: ban address-taken mmap,
mprotect, etc
Product: new-bugs
Version: trunk
Hardware: PC
OS: Linux
Status: NEW
Severity: enhancement
Priority: P
Component: new bugs
Assignee: pe...@pcc.me.uk
Reporter: k...@google.com
CC: eugeni.stepa...@gmail.com, k...@google.com,
llvm-bugs@lists.llvm.org
Classification: Unclassified
In most cases ControlFlowIntegrity will protect from indirectly
calling mmap/mprotect when it is undesired, however if mmap/mprotect is
address-taken
in the application, the protection becomes weaker.
Consider this code:
int (*F)(void *, size_t, int);
...
int some_user_function(void *, size_t, int);
...
F f = &some_user_function;
...
f();
...
// unrelated code
... = &mprotect;
Here, some_user_function and mprotect will be in the same function signature
bucket for CFI and thus the call to f() will allow mprotect.
For stronger security we probably want to disallow indirect calls to scary
functions like mprotect completely.
The simplest way is to implement yet another blacklist: any function in
it will cause a compiler warning/error if address-taken.
We can also introduce a function attribute that leads to a warning
if the function is address-taken.
(This is a no-rush feature request)
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
