https://llvm.org/bugs/show_bug.cgi?id=24858
Bug ID: 24858
Summary: BLX being used in ARMv4 in ARMFastIsel
Product: libraries
Version: trunk
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P
Component: Backend: ARM
Assignee: unassignedb...@nondot.org
Reporter: renato.go...@linaro.org
CC: llvm-bugs@lists.llvm.org
Classification: Unclassified
Following from the bug report detected in Rust when using LLVM:
https://groups.google.com/forum/#!topic/llvm-dev/upPBDqUOLF4
ARMFastIsel doesn't recognise the lack of BLX in ARMv4 sub-architecture when
generating calls.
This commit has added support for global values call but forgot to consider
ARMv4 in the code:
+ if (!GV){
+ CallOpc = isThumb2 ? ARM::tBLXr : ARM::BLX;
+ CalleeReg = getRegForValue(Callee);
+ if (CalleeReg == 0) return false;
+ }
Currently, ARMFastISel::ARMEmitLibcal calls ARMSelectCallOp, which is
implemented similarly:
unsigned ARMFastISel::ARMSelectCallOp(bool UseReg) {
if (UseReg)
return isThumb2 ? ARM::tBLXr : ARM::BLX;
else
return isThumb2 ? ARM::tBL : ARM::BL;
}
which may need to be adapted to cope with ARMv4 hardware, but also be a bit
smarter about what the target is, not only the operand type.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
