mtrofin wrote: > In general this patch LGTM. > > I noticed that one downside of using `-profcheck-weights-for-test` is that > the original branch weights aren't in the test, so it's hard for me to > understand how this change modifies the branch weights.
You're right. I think I'll just use `-profcheck-weights-for-test` "offline" to generate the .ll that is checked in. It's a convenience anyway - to avoid one having to write interesting profile metadata by hand in large tests. wdyt? https://github.com/llvm/llvm-project/pull/159645 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
