https://github.com/Xazax-hun commented:
I am wondering if this is the right approach. If everything works out well, every time we call `Visit` on an expression, there should be a guarantee we already visited all the subexpressions of it (modulo some corner cases with short circuiting operators, ternaries and trivially false branches). So, we might be able to structure the code in a way that we never need to call `Visit` recursively for a subexpression, and we do not need to keep a `VisitedStmts` set. But in case that does not work out for some reason I am also fine with this approach. https://github.com/llvm/llvm-project/pull/153661 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
