[llvm-branch-commits] [llvm] [openmp] [OpenMP][Offload] Add offload runtime support for dyn_groupprivate clause (PR #152831)

[Matt Arsenault via llvm-branch-commits]

================
@@ -4515,6 +4515,15 @@ void omp_free(void *ptr, omp_allocator_handle_t 
allocator) {
 }
 /* end of OpenMP 5.1 Memory Management routines */
 
+void *omp_get_dyn_groupprivate_ptr(size_t offset, int *is_fallback,
+                                   omp_access_t access_group) {
+  if (is_fallback != NULL)
----------------
arsenm wrote:

```suggestion
  if (is_fallback != nullptr)
```

Is there a reason to have an optional out argument? Why not just make it 
unconditional or return a pair?

https://github.com/llvm/llvm-project/pull/152831
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits