https://github.com/boomanaiden154 updated
https://github.com/llvm/llvm-project/pull/152622
>From 8ead35e5d0b9e42d112aba5b728ca73fb23b9769 Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengross...@google.com>
Date: Fri, 8 Aug 2025 14:03:12 +0000
Subject: [PATCH 1/2] feedback
Created using spr 1.3.6
---
.ci/generate_test_report_lib_test.py | 7 -------
1 file changed, 7 deletions(-)
diff --git a/.ci/generate_test_report_lib_test.py
b/.ci/generate_test_report_lib_test.py
index bc96cc7dde554..6023b57ffa538 100644
--- a/.ci/generate_test_report_lib_test.py
+++ b/.ci/generate_test_report_lib_test.py
@@ -654,13 +654,6 @@ def test_generate_report_end_to_end(self):
[5/5] test/5.stamp"""
)
)
- test = generate_test_report_lib.generate_report_from_files(
- "Foo", 1, [junit_xml_file, ninja_log_file]
- )
-
- print(test)
- with open("/tmp/blah", "w") as handle2:
- handle2.write(test)
self.assertEqual(
generate_test_report_lib.generate_report_from_files(
"Foo", 1, [junit_xml_file, ninja_log_file]
>From ae847e587b034fed4371578c28e3e07962eeaec7 Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengross...@google.com>
Date: Fri, 8 Aug 2025 14:35:05 +0000
Subject: [PATCH 2/2] feedback
Created using spr 1.3.6
---
.ci/generate_test_report_lib_test.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.ci/generate_test_report_lib_test.py
b/.ci/generate_test_report_lib_test.py
index e28449022c2f9..cd5af0381cce9 100644
--- a/.ci/generate_test_report_lib_test.py
+++ b/.ci/generate_test_report_lib_test.py
@@ -666,6 +666,9 @@ def test_generate_report_end_to_end(self):
# Foo
* 1 test passed
+
+ All tests passed but another part of the build **failed**.
Click on a failure below to see the details.
+
<details>
<summary>test/4.stamp</summary>
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
