Michael137 wrote:

> > @mizvekov do you have a macOS machine handy to test this on? Or do you want 
> > me to try?
> 
> I don't think there is anything macOS specific about this change.
> 
> My main development machine is macOS, and I always struggled with testing 
> LLDB on it.
> 
> But I finally setup a Linux VM on it, and all that went fine without a single 
> hitch. Besides, our CI is Linux based, and that passes as well.

There are tests that only run on macOS. I just want to avoid a situation where 
we have to revert the entire patch series because of some macOS post-merge test 
failures. Ideally we'd catch these pre-merge on Github, but that's currently 
not set up unfortunately.

Since you don't have the setup, let me run the tests. I'll report back tomorrow

https://github.com/llvm/llvm-project/pull/149949
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to