llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-llvm-ir Author: Matt Arsenault (arsenm) <details> <summary>Changes</summary> These are already the default calls set for these conversions, so they should not require explicit setting. The non-default cases are currently overridden in ARMISelLowering. Just delete this until the list of calls and lowering decisions are separated. This was added back in 6402ad27c01c9503a12d41d7e40646cf0d1f919f. It appears to not be relevant for AArch64, where calls appear to never be used for these. It also appears to not be relevant for x86, where the default calls seem to always end up used anyway. --- Full diff: https://github.com/llvm/llvm-project/pull/148782.diff 1 Files Affected: - (modified) llvm/lib/IR/RuntimeLibcalls.cpp (-9) ``````````diff diff --git a/llvm/lib/IR/RuntimeLibcalls.cpp b/llvm/lib/IR/RuntimeLibcalls.cpp index df529bc013cac..8ca31dff900cb 100644 --- a/llvm/lib/IR/RuntimeLibcalls.cpp +++ b/llvm/lib/IR/RuntimeLibcalls.cpp @@ -77,15 +77,6 @@ void RuntimeLibcallsInfo::initLibcalls(const Triple &TT, setLibcallImpl(RTLIB::UNWIND_RESUME, RTLIB::_Unwind_SjLj_Resume); } - // A few names are different on particular architectures or environments. - if (TT.isOSDarwin()) { - // For f16/f32 conversions, Darwin uses the standard naming scheme, - // instead of the gnueabi-style __gnu_*_ieee. - // FIXME: What about other targets? - setLibcallImpl(RTLIB::FPEXT_F16_F32, RTLIB::__extendhfsf2); - setLibcallImpl(RTLIB::FPROUND_F32_F16, RTLIB::__truncsfhf2); - } - if (TT.isOSOpenBSD()) { setLibcallImpl(RTLIB::STACKPROTECTOR_CHECK_FAIL, RTLIB::Unsupported); } `````````` </details> https://github.com/llvm/llvm-project/pull/148782 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
