https://github.com/svkeerthy updated
https://github.com/llvm/llvm-project/pull/147841
>From 1803736667b49978152af659a2d88a09824adf84 Mon Sep 17 00:00:00 2001
From: svkeerthy <venkatakeer...@google.com>
Date: Wed, 9 Jul 2025 22:38:22 +0000
Subject: [PATCH] [NFC][IR2Vec] Exposing helpers in IR2Vec Vocabulary
---
llvm/include/llvm/Analysis/IR2Vec.h | 16 ++++++++--------
llvm/lib/Analysis/IR2Vec.cpp | 3 ++-
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/llvm/include/llvm/Analysis/IR2Vec.h
b/llvm/include/llvm/Analysis/IR2Vec.h
index 2498a211e80e5..2ad751b2a5aaa 100644
--- a/llvm/include/llvm/Analysis/IR2Vec.h
+++ b/llvm/include/llvm/Analysis/IR2Vec.h
@@ -162,6 +162,14 @@ class Vocabulary {
static constexpr unsigned MaxOperandKinds =
static_cast<unsigned>(OperandKind::MaxOperandKind);
+public:
+ Vocabulary() = default;
+ Vocabulary(VocabVector &&Vocab);
+
+ bool isValid() const;
+ unsigned getDimension() const;
+ size_t size() const;
+
/// Helper function to get vocabulary key for a given Opcode
static StringRef getVocabKeyForOpcode(unsigned Opcode);
@@ -174,14 +182,6 @@ class Vocabulary {
/// Helper function to classify an operand into OperandKind
static OperandKind getOperandKind(const Value *Op);
-public:
- Vocabulary() = default;
- Vocabulary(VocabVector &&Vocab);
-
- bool isValid() const;
- unsigned getDimension() const;
- size_t size() const;
-
/// Accessors to get the embedding for a given entity.
const ir2vec::Embedding &operator[](unsigned Opcode) const;
const ir2vec::Embedding &operator[](Type::TypeID TypeId) const;
diff --git a/llvm/lib/Analysis/IR2Vec.cpp b/llvm/lib/Analysis/IR2Vec.cpp
index c6e1fa32c9ffd..d3d0c30bd05a7 100644
--- a/llvm/lib/Analysis/IR2Vec.cpp
+++ b/llvm/lib/Analysis/IR2Vec.cpp
@@ -502,7 +502,8 @@ IR2VecVocabAnalysis::run(Module &M, ModuleAnalysisManager
&AM) {
// Otherwise, try to read from the vocabulary file.
if (VocabFile.empty()) {
// FIXME: Use default vocabulary
- Ctx->emitError("IR2Vec vocabulary file path not specified");
+ Ctx->emitError("IR2Vec vocabulary file path not specified; You may need to
"
+ "set it using --ir2vec-vocab-path");
return Vocabulary(); // Return invalid result
}
if (auto Err = readVocabulary()) {
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
