jhuber6 wrote:

> @jhuber6 Given that this interface matches the interface of other handles, 
> any change to how it fundamentally works should probably involve updating all 
> other getInfo queries. If we do decide to replace the Size variants, I think 
> that should be done as a separate task that touches everything.
> 
> For now, I think it makes sense to match other handle points, and leave any 
> refactors for device info as a separate change that touches everything.

Sure, we can get in and then rework all the get info's to just have a separate 
query for the size. I think that's much cleaner and keeps the number of API 
functions more clear. I'll accept this for now but we should definitely do that 
later.

https://github.com/llvm/llvm-project/pull/147962
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to