Author: Philipp van Kempen Date: 2025-01-13T11:50:27+01:00 New Revision: 9969e7f8783102e2b2b4ec478bb4a8aaeb6f41a2
URL: https://github.com/llvm/llvm-project/commit/9969e7f8783102e2b2b4ec478bb4a8aaeb6f41a2 DIFF: https://github.com/llvm/llvm-project/commit/9969e7f8783102e2b2b4ec478bb4a8aaeb6f41a2.diff LOG: [RISCV] Fix typo in CV_SH_rr_inc pattern (#120246) This typo in https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/RISCV/RISCVInstrInfoXCV.td#L701:L701 caused a compiler crash in 'RISC-V Assembly Printer' because CV_SH_ri_inc was selected, leading to `getImmOpValue` being called for a register operand. This bug did not affect the Assembler output and therefore does not trigger any existing unit tests, but is visible by examining the final MIR function. (cherry picked from commit e8ce6c4e69745b1b2cd6f7479c48fbae44622cb3) Added: Modified: llvm/lib/Target/RISCV/RISCVInstrInfoXCV.td Removed: ################################################################################ diff --git a/llvm/lib/Target/RISCV/RISCVInstrInfoXCV.td b/llvm/lib/Target/RISCV/RISCVInstrInfoXCV.td index 3bd6da28682863..99485981701479 100644 --- a/llvm/lib/Target/RISCV/RISCVInstrInfoXCV.td +++ b/llvm/lib/Target/RISCV/RISCVInstrInfoXCV.td @@ -694,7 +694,7 @@ let Predicates = [HasVendorXCVmem, IsRV32], AddedComplexity = 1 in { def : CVStriPat<post_store, CV_SW_ri_inc>; def : CVStrriPat<post_truncsti8, CV_SB_rr_inc>; - def : CVStrriPat<post_truncsti16, CV_SH_ri_inc>; + def : CVStrriPat<post_truncsti16, CV_SH_rr_inc>; def : CVStrriPat<post_store, CV_SW_rr_inc>; def : CVStrrPat<truncstorei8, CV_SB_rr>; _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
