================ @@ -638,6 +638,10 @@ static unsigned getMaxCounterID(const CounterMappingContext &Ctx, unsigned MaxCounterID = 0; for (const auto &Region : Record.MappingRegions) { MaxCounterID = std::max(MaxCounterID, Ctx.getMaxCounterID(Region.Count)); + if (Region.Kind == CounterMappingRegion::BranchRegion || ---------------- ornata wrote:
I feel like it would be nice to add helpers for Region.Kind just to make the code a little easier to read. E.g. ``` isBranchRegion(Region) { return Region.Kind == CounterMappingRegion::BranchRegion; } isMCDCBranchRegion(Region) ``` Maybe in a follow-up commit? https://github.com/llvm/llvm-project/pull/112730 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits