================
@@ -537,6 +537,10 @@ class ConversionPattern : public RewritePattern {
                        ConversionPatternRewriter &rewriter) const {
     llvm_unreachable("unimplemented rewrite");
   }
+  virtual void rewrite(Operation *op, ArrayRef<ValueRange> operands,
----------------
zero9178 wrote:

Think it'd be useful here to add doc comments how this differs from the other 
rewrite overload so that readers know when they'd want to (or are required to) 
use this overload rather than the other. 

https://github.com/llvm/llvm-project/pull/116470
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to