dtcxzyw wrote: > Hi, since we are wrapping up LLVM 19.1.0 we are very strict with the fixes we > pick at this point. Can you please respond to the following questions to help > me understand if this has to be included in the final release or not. > > Is this PR a fix for a regression or a critical issue?
Yes. It fixes a miscompilation reported in https://github.com/llvm/llvm-project/pull/107432. > What is the risk of accepting this into the release branch? It introduces a performance regression. I have filed an issue to track this: https://github.com/llvm/llvm-project/issues/107946. > What is the risk of NOT accepting this into the release branch? ISel for 32-bit signed div/rem stays broken on LoongArch64. https://github.com/llvm/llvm-project/pull/107945 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
