================
@@ -702,14 +702,8 @@ class UnresolvedMaterializationRewrite : public 
OperationRewrite {
     return rewrite->getKind() == Kind::UnresolvedMaterialization;
   }
 
-  UnrealizedConversionCastOp getOperation() const {
----------------
zero9178 wrote:

I think it would be cleaner to keep this method for the code below, warn about 
the issue of potentially being erased and the need to check for it, and then 
add a method `bool erasedRewrite(OperationRewrite* rewrite)` or similar to 
`SingleEraseRewriter`. Since the static type is then `OperationRewrite` it'd be 
accessing the `Operation*`

https://github.com/llvm/llvm-project/pull/104668
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to