https://github.com/skatrak commented:
Thank you for picking up this work. In general it looks good, but apart from some nits I think some improvements can be made to the op verifiers as well. Also, please update mlir/test/Dialect/OpenMP/ops.mlir to add the `omp.composite` attribute to all ops representing a composite construct, as well as adding test cases to mlir/test/Dialect/OpenMP/invalid.mlir to test each of the new error cases. https://github.com/llvm/llvm-project/pull/102341 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
