https://github.com/MaskRay approved this pull request.

I am not familiar with how the tests cmake work, but this patch indeed improves 
consistency.

For example, `foreach(arch ${MEMPROF_TEST_ARCH})` is at the toplevel while its 
unittest `foreach` is guarded by `COMPILER_RT_INCLUDE_TESTS`. Removing 
`COMPILER_RT_INCLUDE_TESTS` is great.


https://github.com/llvm/llvm-project/pull/98246
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to