jayfoad wrote: > > This looks like it is affecting codegen even when xnack is disabled? That > > should not happen. > > It shouldn't. I put the xnack replay subtarget check before using *_ec > equivalents. See the code here: > [65eb443#diff-35f4d1b6c4c17815f6989f86abbac2e606ca760f9d93f501ff503449048bf760R1735](https://github.com/llvm/llvm-project/commit/65eb44327cf32a83dbbf13eb70f9d8c03f3efaef#diff-35f4d1b6c4c17815f6989f86abbac2e606ca760f9d93f501ff503449048bf760R1735)
You're checking `STI->hasXnackReplay()` which is true on all GFX8+ targets. You should be checking whether xnack support is enabled with `STI->isXNACKEnabled()`. https://github.com/llvm/llvm-project/pull/96162 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
