tblah wrote: > @tblah thanks for giving this a look. Basically the issue here with the > reduction clause is that its description is currently different for each > operation that accepts it.
> It would be great to agree on a generic description for that clause that > would work for all ops, so that it makes sense while reading the generated > documentation and also being centralized into the clause definition rather > than each operation. I created a gist > [here](https://gist.github.com/skatrak/ee6e1829980867f8119f91f84cb284b1) with > the whole list of descriptions that currently exist for `reduction`, in case > that helps with figuring out a shared description. Thanks for taking the time to create the gist. Some thoughts - I think some of the descriptions are out of date. `omp.reduction` has been removed: https://github.com/llvm/llvm-project/pull/92732 - Assuming that `omp.reduction` really was unused, I think that leaves byref as the main difference? I guess fixing byref is on me (https://github.com/llvm/llvm-project/pull/92244). Unfortunately I can't work on this immediately so I won't hold up this PR for it. https://github.com/llvm/llvm-project/pull/92523 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
