https://github.com/MatzeB commented:

I guess this is deliberately designed around a `bool IsExpected` rather than a 
more generic API. I guess I'm fine with it given the current patch, though I 
would bet it's just a question of time for someone to add more sources now... 
(so gotta make sure to turn the API into a generic one when there is more 
sources coming around)

Added a bunch of nitpicks, naming discussions etc. Though all-in-all this looks 
good to me.

https://github.com/llvm/llvm-project/pull/86609
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to