=?utf-8?q?Andrés?= Villegas <andre...@google.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/77...@github.com>


================
@@ -0,0 +1,33 @@
+// COM: End to end test for the sanitizer symbolizer markup. Since it uses 
debug info
+// COM: to do offline symbolization we only check that the current module is 
correctly symbolized
+// REQUIRES: linux
+// RUN: %clangxx_asan %s -Wl,--build-id=0x12345678 -o %t.main
+// RUN: mkdir -p %t/.build-id/12
----------------
ilovepi wrote:

```suggestion
// RUN: rm -rf %t
// RUN: mkdir -p %t/.build-id/12
// RUN: %clangxx_asan %s -Wl,--build-id=0x12345678 -o %t/main
```
Its normal to remove the old test dir before doing trying to make a new one or 
add to it. It also makes sense to put any artifacts into the temp dir you're 
going to remove, so each run is self contained.

You'll need to adjust the other commands to match.

https://github.com/llvm/llvm-project/pull/77702
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to