Author: Louis Dionne Date: 2021-01-18T14:41:53-05:00 New Revision: 01a13f127a8b17c7827cc19302fc612532249795
URL: https://github.com/llvm/llvm-project/commit/01a13f127a8b17c7827cc19302fc612532249795 DIFF: https://github.com/llvm/llvm-project/commit/01a13f127a8b17c7827cc19302fc612532249795.diff LOG: [libc++] Rename check-cxx-deps to cxx-test-depends for consistency Several subprojects have targets that do the same thing, and they all follow the same naming convention: llvm-test-depends, clang-test-depends, lld-test-depends, etc. This makes libc++ consistent with other LLVM projects. Thanks to Duncan Exon Smith for noticing and suggesting the change. Differential Revision: https://reviews.llvm.org/D94499 Added: Modified: libcxx/docs/TestingLibcxx.rst libcxx/test/CMakeLists.txt Removed: ################################################################################ diff --git a/libcxx/docs/TestingLibcxx.rst b/libcxx/docs/TestingLibcxx.rst index 04930e14ffae..ae014729c12f 100644 --- a/libcxx/docs/TestingLibcxx.rst +++ b/libcxx/docs/TestingLibcxx.rst @@ -27,12 +27,12 @@ Usage After building libc++, you can run parts of the libc++ test suite by simply running ``llvm-lit`` on a specified test or directory. If you're unsure whether the required libraries have been built, you can use the -`check-cxx-deps` target. For example: +`cxx-test-depends` target. For example: .. code-block:: bash $ cd <monorepo-root> - $ make -C <build> check-cxx-deps # If you want to make sure the targets get rebuilt + $ make -C <build> cxx-test-depends # If you want to make sure the targets get rebuilt $ <build>/bin/llvm-lit -sv libcxx/test/std/re # Run all of the std::regex tests $ <build>/bin/llvm-lit -sv libcxx/test/std/depr/depr.c.headers/stdlib_h.pass.cpp # Run a single test $ <build>/bin/llvm-lit -sv libcxx/test/std/atomics libcxx/test/std/threads # Test std::thread and std::atomic @@ -87,7 +87,7 @@ configuration easier. .. code-block:: bash $ cmake <options> -DLIBCXX_TEST_CONFIG=<path-to-site-config> - $ make -C <build> check-cxx-deps + $ make -C <build> cxx-test-depends $ <build>/bin/llvm-lit -sv libcxx/test # will use your custom config file diff --git a/libcxx/test/CMakeLists.txt b/libcxx/test/CMakeLists.txt index e9a886964d80..7173e22d615d 100644 --- a/libcxx/test/CMakeLists.txt +++ b/libcxx/test/CMakeLists.txt @@ -99,14 +99,14 @@ if (LIBCXX_INCLUDE_TESTS) ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg MAIN_CONFIG "${CMAKE_CURRENT_SOURCE_DIR}/lit.cfg.py") - add_custom_target(check-cxx-deps + add_custom_target(cxx-test-depends DEPENDS cxx ${LIBCXX_TEST_DEPS} COMMENT "Builds dependencies required to run the test suite.") add_lit_target(check-cxx "Running libcxx tests" ${CMAKE_CURRENT_BINARY_DIR} - DEPENDS check-cxx-deps + DEPENDS cxx-test-depends PARAMS "${LIBCXX_TEST_PARAMS}") endif() _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
