Author: Kazu Hirata Date: 2021-01-18T10:16:33-08:00 New Revision: 28ea50f524b56e11b608ca1f768d2981579ebe75
URL: https://github.com/llvm/llvm-project/commit/28ea50f524b56e11b608ca1f768d2981579ebe75 DIFF: https://github.com/llvm/llvm-project/commit/28ea50f524b56e11b608ca1f768d2981579ebe75.diff LOG: [llvm] Populate std::vector at construction time (NFC) Added: Modified: llvm/lib/ObjectYAML/DWARFEmitter.cpp llvm/lib/ObjectYAML/MachOEmitter.cpp llvm/lib/ProfileData/SampleProf.cpp Removed: ################################################################################ diff --git a/llvm/lib/ObjectYAML/DWARFEmitter.cpp b/llvm/lib/ObjectYAML/DWARFEmitter.cpp index 0584ef0aadca..eec733c7d7f9 100644 --- a/llvm/lib/ObjectYAML/DWARFEmitter.cpp +++ b/llvm/lib/ObjectYAML/DWARFEmitter.cpp @@ -63,8 +63,7 @@ static Error writeVariableSizedInteger(uint64_t Integer, size_t Size, } static void ZeroFillBytes(raw_ostream &OS, size_t Size) { - std::vector<uint8_t> FillData; - FillData.insert(FillData.begin(), Size, 0); + std::vector<uint8_t> FillData(Size, 0); OS.write(reinterpret_cast<char *>(FillData.data()), Size); } diff --git a/llvm/lib/ObjectYAML/MachOEmitter.cpp b/llvm/lib/ObjectYAML/MachOEmitter.cpp index 9eba391032b9..dec9c9f6960b 100644 --- a/llvm/lib/ObjectYAML/MachOEmitter.cpp +++ b/llvm/lib/ObjectYAML/MachOEmitter.cpp @@ -199,14 +199,12 @@ size_t writeLoadCommandData<MachO::build_version_command>( } void ZeroFillBytes(raw_ostream &OS, size_t Size) { - std::vector<uint8_t> FillData; - FillData.insert(FillData.begin(), Size, 0); + std::vector<uint8_t> FillData(Size, 0); OS.write(reinterpret_cast<char *>(FillData.data()), Size); } void Fill(raw_ostream &OS, size_t Size, uint32_t Data) { - std::vector<uint32_t> FillData; - FillData.insert(FillData.begin(), (Size / 4) + 1, Data); + std::vector<uint32_t> FillData((Size / 4) + 1, Data); OS.write(reinterpret_cast<char *>(FillData.data()), Size); } diff --git a/llvm/lib/ProfileData/SampleProf.cpp b/llvm/lib/ProfileData/SampleProf.cpp index 809576c57ffc..d6acc00e1a6f 100644 --- a/llvm/lib/ProfileData/SampleProf.cpp +++ b/llvm/lib/ProfileData/SampleProf.cpp @@ -287,8 +287,7 @@ std::error_code ProfileSymbolList::read(const uint8_t *Data, std::error_code ProfileSymbolList::write(raw_ostream &OS) { // Sort the symbols before output. If doing compression. // It will make the compression much more effective. - std::vector<StringRef> SortedList; - SortedList.insert(SortedList.begin(), Syms.begin(), Syms.end()); + std::vector<StringRef> SortedList(Syms.begin(), Syms.end()); llvm::sort(SortedList); std::string OutputString; @@ -303,8 +302,7 @@ std::error_code ProfileSymbolList::write(raw_ostream &OS) { void ProfileSymbolList::dump(raw_ostream &OS) const { OS << "======== Dump profile symbol list ========\n"; - std::vector<StringRef> SortedList; - SortedList.insert(SortedList.begin(), Syms.begin(), Syms.end()); + std::vector<StringRef> SortedList(Syms.begin(), Syms.end()); llvm::sort(SortedList); for (auto &Sym : SortedList) _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
