Author: Kazu Hirata Date: 2020-12-26T12:06:27-08:00 New Revision: b676f2fee1f5f4ad1a5280b11554b5d18c4d5a71
URL: https://github.com/llvm/llvm-project/commit/b676f2fee1f5f4ad1a5280b11554b5d18c4d5a71 DIFF: https://github.com/llvm/llvm-project/commit/b676f2fee1f5f4ad1a5280b11554b5d18c4d5a71.diff LOG: [llvm-cov, llvm-symbolizer] Use llvm::erase_if (NFC) Added: Modified: llvm/tools/llvm-cov/CodeCoverage.cpp llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp Removed: ################################################################################ diff --git a/llvm/tools/llvm-cov/CodeCoverage.cpp b/llvm/tools/llvm-cov/CodeCoverage.cpp index 8ef4b747a0fb..a453e975fca9 100644 --- a/llvm/tools/llvm-cov/CodeCoverage.cpp +++ b/llvm/tools/llvm-cov/CodeCoverage.cpp @@ -436,16 +436,11 @@ void CodeCoverageTool::remapPathNames(const CoverageMapping &Coverage) { void CodeCoverageTool::removeUnmappedInputs(const CoverageMapping &Coverage) { std::vector<StringRef> CoveredFiles = Coverage.getUniqueSourceFiles(); - auto UncoveredFilesIt = SourceFiles.end(); // The user may have specified source files which aren't in the coverage // mapping. Filter these files away. - UncoveredFilesIt = std::remove_if( - SourceFiles.begin(), SourceFiles.end(), [&](const std::string &SF) { - return !std::binary_search(CoveredFiles.begin(), CoveredFiles.end(), - SF); - }); - - SourceFiles.erase(UncoveredFilesIt, SourceFiles.end()); + llvm::erase_if(SourceFiles, [&](const std::string &SF) { + return !std::binary_search(CoveredFiles.begin(), CoveredFiles.end(), SF); + }); } void CodeCoverageTool::demangleSymbols(const CoverageMapping &Coverage) { diff --git a/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp b/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp index 358e0e284fca..9c68acee0ae2 100644 --- a/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp +++ b/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp @@ -329,10 +329,8 @@ int main(int argc, char **argv) { while (fgets(InputString, sizeof(InputString), stdin)) { // Strip newline characters. std::string StrippedInputString(InputString); - StrippedInputString.erase( - std::remove_if(StrippedInputString.begin(), StrippedInputString.end(), - [](char c) { return c == '\r' || c == '\n'; }), - StrippedInputString.end()); + llvm::erase_if(StrippedInputString, + [](char c) { return c == '\r' || c == '\n'; }); symbolizeInput(Args, AdjustVMA, IsAddr2Line, OutputStyle, StrippedInputString, Symbolizer, Printer); outs().flush(); _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
