Greg, what do you think?
On Tue, Mar 12, 2019 at 11:50 AM Qianli Ma <chienl...@google.com> wrote: > Hi lldb community, > > I am currently working on a project related to lldb. I'd like to write a > DAP RPC server similars to lldb-vscode.cc > <https://github.com/llvm-mirror/lldb/blob/master/tools/lldb-vscode/lldb-vscode.cpp> > but > exports I/O to internal RPC clients. Doing so requires me to reuse some > functions defined in lldb-vscode.cc > <https://github.com/llvm-mirror/lldb/blob/master/tools/lldb-vscode/lldb-vscode.cpp>. > However as those functions are defined using forward declaration I am not > able to do that. > > I'd like refactor the code a bit. More specifically, I'd like to extract > all helper functions in lldb-vscode.cc > <https://github.com/llvm-mirror/lldb/blob/master/tools/lldb-vscode/lldb-vscode.cpp> > into > a separate file and create a header for it. BTW, IMO it's good to make > this lldb-vscode more general so that it can be used by other debugger > frontends besides vscode. > > Please let me know WDYT and how I can proceed to submit changes for > review. > > Thanks and Regards > Qianli >
_______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
