We now have architecture plug-ins. Target::GetCallableLoadAddress should defer to the architecture plug-ins and any functionality should be moved into those plug-ins. There is one for ARM. We will need to make one for MIPS.
> On Jun 21, 2018, at 1:58 PM, Jim Ingham via lldb-dev > <lldb-dev@lists.llvm.org> wrote: > > It's actually a little lame that we have a switch over architectures in > generic Target code. This should be gotten from the architecture plugin. > GetBreakableLoadAddress is even worse, there's ~150 lines of MIPS specific > code in Target.cpp, which seems really wrong to me. > > Not really answering your question except formally none of this code should > be in Target.cpp... > > Jim > > >> On Jun 21, 2018, at 11:52 AM, Tatyana Krasnukha via lldb-dev >> <lldb-dev@lists.llvm.org> wrote: >> >> Hi, >> >> It seems Target::GetCallableLoadAddress does equivalent things for arm/thumb >> and for mipses, just written in different forms. May I join these cases >> together? >> _______________________________________________ >> lldb-dev mailing list >> lldb-dev@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > > _______________________________________________ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev _______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
