If this isn't used, then this should be removed. Anything dynamic settings that are retrieved need to be abstracted into this class. There isn't a need for an extra plug-in as ProcessGDBRemote handles all variants of GDB remote servers and it should encapsulate all that is needed to use any GDB server.
> On Nov 3, 2017, at 7:27 AM, Tatyana Krasnukha via lldb-dev > <lldb-dev@lists.llvm.org> wrote: > > Hello, > > I have questions about ProcessGDBRemote::m_flags member. Seems like it is > never used. What is the purpose of it and what is the reason to do accessors > protected, even constant getter? And other question: isn’t it better to move > this member to new plugin Architecture to be able to store dynamic > architecture features (read from target’s configuration registers, for > example)? > _______________________________________________ > lldb-dev mailing list > lldb-dev@lists.llvm.org <mailto:lldb-dev@lists.llvm.org> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > <http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev>
_______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
