I think that approach is kind of a bandaid. Core files can't resume, so it would be better to figure out why telling a core file which can't resume to resume caused us to go into a tail spin. That should just fall out of WillResume returning false or some other better general signal. Special-casing core files seems a bit of a hack.
That being said, if nobody has time to make a better solution, a bandaid is better than bleeding... Jim > On Nov 10, 2016, at 5:53 AM, Howard Hellyer via lldb-dev > <lldb-dev@lists.llvm.org> wrote: > > I've been hitting a hang when lldb loads some core dumps created on Linux, > generally those created via gcore. > > I found an open bug for this here: > https://llvm.org/bugs/show_bug.cgi?id=26322 > and the fix that was suggested there still works. (The patch needs some > tidying up due to the code formatting changes.) > > I'd quite like to take that change and submit an updated patch via > phabricator. Since no-one else has done that so far I was wondering if there > was a problem with the approach it took or just a question of time. The patch > just adds a flag to say that the process was loaded from a core file and uses > that as a simple check to see if lldb should wait for the process to resume > or not. Doing that works around changing the logic for working out the thread > states. I'm not sure if that's bad as it avoids fixing the thread state logic > or good as it allows the core to load without needing to change the thread > states from the state they were in when the core file was created. > > If no-one objects I'll grab the bug and submit a patch, otherwise please let > me know and I'll look at fixing it another way. > > Thanks, > > Howard Hellyer > IBM Runtime Technologies, IBM Systems > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > _______________________________________________ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev _______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
