Shouldn't this be made general and added to the llvm coding conventions? I was assuming that upon completion of this exercise, we would delete the lldb coding conventions doc.
Jim > On Aug 11, 2016, at 11:20 AM, Zachary Turner via lldb-dev > <lldb-dev@lists.llvm.org> wrote: > > On Wed, Aug 10, 2016 at 10:37 PM Chris Lattner <clatt...@apple.com> wrote: > >> On Aug 9, 2016, at 3:01 PM, Zachary Turner via lldb-dev >> <lldb-dev@lists.llvm.org> wrote: >> >> So perhaps it would be reasonable for us to standardize on something like >> this: >> >> • Main Module Header >> • Local/Private Headers >> • lldb/... >> • llvm/... >> • System #includes > > This makes sense to me, and matches what clang does as well. I think that > this is clearly in the spirit of the llvm include order standards, and I > think it would be great to make this explicit in the coding standard doc. > Can you send in a patch to update it to make this explicit? I’ll review it. > > -Chris > > I actually just submitted the patch. (Sorry, itchy trigger finger or > something). r278373. If you have any comments let me know and I'm happy to > iterate on it. > > _______________________________________________ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev _______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
