I understand your concern. I guess it could be possible to create a conditional test exercised on a particular condition (like the presence of the native compiler), and skipped otherwise. Is it possible for new files to trigger regressions? Most of the changes concern the language plugins, AST context and DWARF parser.
Elias From: ztur...@google.com Date: Thu, 7 Jul 2016 16:05:06 +0000 Subject: Re: [lldb-dev] Add support for OCaml native debugging To: tbergham...@google.com; e.bouta...@hotmail.fr; lldb-dev@lists.llvm.org I don't like the idea of not having tests. Promising tests and actually delivering on them are two entirely different things. And without them, we just end up with broken code and nobody to maintain it On Thu, Jul 7, 2016 at 6:23 AM Tamas Berghammer via lldb-dev <lldb-dev@lists.llvm.org> wrote: What type of binaries do you want to commit in? Generally we don't like putting binaries to the repository because they are not human readable so it is hard to review/diff them and they will only run on a single platform and a single architecture while we support a lot of different configuration. Tamas On Wed, Jul 6, 2016 at 3:26 PM E BOUTALEB via lldb-dev <lldb-dev@lists.llvm.org> wrote: I would like to submit two patches for code review. They introduce concrete support for OCaml native debugging, granted that you have access to the native compiler with DWARF emission support (see https://github.com/ocaml/ocaml/pull/574) This adds about 2000 lines of code. The type system isn't particularly complex here, every value is considered as an unsigned integer, and interpretation of the value is left to an external debugging layer made in OCaml. The language plugin handles function name demangling for breakpoints too. No tests for now. Is it fine to commit binaries with the patchs? Elias Boutaleb _______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev _______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
_______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
