In further changes please add me to review, I will test the standalone build.
Yes, I'm running an installed version of llvm-config and I don't have sources neither build files. On 17.05.2016 10:05, Pavel Labath via lldb-dev wrote: > Ok, I see what the problem is now. If you run llvm-config from the > build folder, it will print out the correct path for the llvm headers, > but this will not be correct for the clang headers as it points > directly to the subfolder of the source llvm checkout. In Kamil's use > case this will be fine since he is presumably running an installed > llvm-config, in which case it ends up pointing us to the installed > headers under /usr/lib, and if you install clang to the same location > everything is fine. > > So, it sounds to me like we should resurrect the CLANG_BUILD and > CLANG_SOURCE (a poor man's version of clang-config) variables that got > removed. There should be no need for the LLVM vars, as llvm-config > should cover that, right? Can you prepare a patch for that? > > pl > > On 17 May 2016 at 00:36, Eugene Zelenko via lldb-dev > <lldb-dev@lists.llvm.org> wrote: >> Hi, Pavel! >> >> On Mon, May 16, 2016 at 3:04 AM, Pavel Labath <lab...@google.com> wrote: >>> Hi Eugene, >>> >>> my thoughts on this are inline. >>> >>> At which stage does the build now fail for you (after applying the >>> fixes above)? >> >> Build failed at very beginning: >> >> source/lldb.cpp:19:10: fatal error: 'clang/Basic/Version.h' file not found >> >> But there are much more places which depends on Clang headers (AST, Basic). >> >>> As Kamil said, LLDB really shouldn't depend on the clang source >>> folder. The only dependency I know of is the uglyness in lldb-mi, but >>> it looks like it should be easy to fix (basically, lldb-mi should use >>> the public regex interface instead of the private one, porting >>> appeared straight-forward), so I think someone should just bite the >>> bullet and do it. If you need any more changes after that, we can look >>> into that then. >> >> I build LLVM/Clang/ect with LLVM_INSTALL_TOOLCHAIN_ONLY=ON, so source >> and build directories are needed for headers and libraries. I try to >> save disc space for final installation and we don't use LLVM/Clang >> headers/libraries internally, so source and build directories were >> good enough for us. >> >> Eugene. >> _______________________________________________ >> lldb-dev mailing list >> lldb-dev@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > _______________________________________________ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > _______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
