clayborg wrote:

> > What happens if we stop preferring the external symbols over internal ones 
> > in IRExecutionUnit::FindInSymbols? What tests break?
> 
> It looks like there are no failing tests.

We should always prefer symbols from the current module first, probably 
external first, then fall back to internal. If we do a search of all modules, 
we should prefer external symbols first and then internal, but only if they are 
unique. Just think about how a symbol would be resolved inside of a shared 
library vs how it would get accessed from outside of the shared library. 
Debuggers can break the rules when we need to, but we should try to stay true 
to how things would actually happen when possible first.

https://github.com/llvm/llvm-project/pull/102835
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to