[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 675c748bb606d75a959481e6014299849cf3094c 
32786ae0abb7c465dfab602b1d53da11dd1dc7a7 --extensions h,cpp -- 
lldb/test/API/lang/cpp/std-invoke-recognizer/main.cpp 
lldb/include/lldb/Target/StackFrameRecognizer.h 
lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp 
lldb/source/Target/StackFrameRecognizer.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/include/lldb/Target/StackFrameRecognizer.h 
b/lldb/include/lldb/Target/StackFrameRecognizer.h
index 4ef0d1b2f5..ff10a7ada5 100644
--- a/lldb/include/lldb/Target/StackFrameRecognizer.h
+++ b/lldb/include/lldb/Target/StackFrameRecognizer.h
@@ -105,16 +105,15 @@ private:
 /// Class that provides a registry of known stack frame recognizers.
 class StackFrameRecognizerManager {
 public:
-  void AddRecognizer(lldb::StackFrameRecognizerSP recognizer,
-                     ConstString module, llvm::ArrayRef<ConstString> symbols,
-                     bool first_instruction_only = true,
-                     Mangled::NamePreference mangling_preference = 
Mangled::ePreferDemangled);
-
-  void AddRecognizer(lldb::StackFrameRecognizerSP recognizer,
-                     lldb::RegularExpressionSP module,
-                     lldb::RegularExpressionSP symbol,
-                     bool first_instruction_only = true,
-                     Mangled::NamePreference mangling_preference = 
Mangled::ePreferDemangled);
+  void AddRecognizer(
+      lldb::StackFrameRecognizerSP recognizer, ConstString module,
+      llvm::ArrayRef<ConstString> symbols, bool first_instruction_only = true,
+      Mangled::NamePreference mangling_preference = Mangled::ePreferDemangled);
+
+  void AddRecognizer(
+      lldb::StackFrameRecognizerSP recognizer, lldb::RegularExpressionSP 
module,
+      lldb::RegularExpressionSP symbol, bool first_instruction_only = true,
+      Mangled::NamePreference mangling_preference = Mangled::ePreferDemangled);
 
   void ForEach(std::function<
                void(uint32_t recognizer_id, std::string recognizer_name,
diff --git 
a/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp 
b/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
index bfd23ed9c3..38ebfcf392 100644
--- a/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
+++ b/lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
@@ -106,8 +106,8 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
     process->GetTarget().GetFrameRecognizerManager().AddRecognizer(
         StackFrameRecognizerSP(new LibCXXFrameRecognizer()), {},
         std::make_shared<RegularExpression>("^std::__[0-9]*::"),
-        /*first_instruction_only=*/ false,
-        /*mangling_preference=*/ Mangled::ePreferDemangledWithoutArguments);
+        /*first_instruction_only=*/false,
+        /*mangling_preference=*/Mangled::ePreferDemangledWithoutArguments);
 }
 
 bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/105695
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits