================
@@ -329,6 +330,11 @@ class DynamicLoader : public PluginInterface {
   /// safe to call certain APIs or SPIs.
   virtual bool IsFullyInitialized() { return true; }
 
+  /// Return the `start` function \b symbol in the dynamic loader module.
+  virtual llvm::Expected<lldb_private::Symbol> GetStartSymbol() {
----------------
jasonmolenda wrote:

Should this be an llvm::Expected?  It's only going to be defined for 
DynamicLoaderDarwin today.  If some generic code wanted to use this, where it 
may not be applicable or defined for another DynamicLoader plugin, it'll need 
to consume the UnimplementedError.  Given the optionality of it, a 
std::optional seems more natural to me maybe?

https://github.com/llvm/llvm-project/pull/99673
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to