labath wrote:

> > It may be better to split this into smaller patches, given the fragility of 
> > this code. (Basically, one patch for each of your bullet points).
> 
> I was thinking about that, but for me it looked like path_wrapper thing and 
> cross-compilation/sdkroot fixes should have been sent in the same commit 
> since each of them is insufficient for setting this configuration up on 
> Windows.

I understand. In terms of raw LOC, this patch isn't really big, but it has some 
fragile and potentially controversial parts, so I think it'd be easier to 
handle it in parts. Thanks for splitting it up.

https://github.com/llvm/llvm-project/pull/99266
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to