kevinfrei wrote:

> @kevinfrei , I'm so sorry to tell you that I have reverted this patch. The 
> revert commit is 
> [27b2f4f](https://github.com/llvm/llvm-project/commit/27b2f4f861b8aeeabc4eb1a97649062de8fa3992)
>  and I left some notes there, which I also copy here:
> 
> The patch #98344 causes a crash in LLDB when parsing some files like 
> `numpy.libs/libgfortran-daac5196.so.5.0.0` on graviton (you can download it 
> in 
> https://drive.google.com/file/d/12ygLjJwWpzdYsrzBPp1JGiFHxcgM0-XY/view?usp=drive_link
>  if you want to troubleshoot yourself).
> 
> ```
> The assert that is hit is the following:
> 
> ```
> llvm-project/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2452: 
> std::pair<unsigned int, std::map<long unsigned int, 
> lldb_private::AddressClass> > 
> ObjectFileELF::ParseSymbolTable(lldb_private::Symtab*, lldb::user_id_t, 
> lldb_private::Section*): Assertion `strtab->GetObjectFile() == this' failed.
> ```

Reverted with a repro instead of some inscrutable "This didn't work on a build 
machine configured by someone 4 years ago who promptly forgot what they did and 
there's no documentation, but here's this log: good luck!" is glorious! I'll 
get on it- thanks 😃 

https://github.com/llvm/llvm-project/pull/98344
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to