llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) <details> <summary>Changes</summary> The help output incorrectly states that this command takes a shared library name (<shlib-name>) while really it takes a path to a symbol file. rdar://131777043 --- Full diff: https://github.com/llvm/llvm-project/pull/98976.diff 2 Files Affected: - (modified) lldb/source/Commands/CommandObjectTarget.cpp (+1-1) - (modified) lldb/test/Shell/SymbolFile/add-dsym.test (+3) ``````````diff diff --git a/lldb/source/Commands/CommandObjectTarget.cpp b/lldb/source/Commands/CommandObjectTarget.cpp index 80181a9b3cb71..d594330934ad7 100644 --- a/lldb/source/Commands/CommandObjectTarget.cpp +++ b/lldb/source/Commands/CommandObjectTarget.cpp @@ -4252,7 +4252,7 @@ class CommandObjectTargetSymbolsAdd : public CommandObjectParsed { m_option_group.Append(&m_current_stack_option, LLDB_OPT_SET_2, LLDB_OPT_SET_2); m_option_group.Finalize(); - AddSimpleArgumentList(eArgTypeShlibName); + AddSimpleArgumentList(eArgTypeFilename); } ~CommandObjectTargetSymbolsAdd() override = default; diff --git a/lldb/test/Shell/SymbolFile/add-dsym.test b/lldb/test/Shell/SymbolFile/add-dsym.test index cdcba641957d1..52d1a1363feef 100644 --- a/lldb/test/Shell/SymbolFile/add-dsym.test +++ b/lldb/test/Shell/SymbolFile/add-dsym.test @@ -1,5 +1,8 @@ # REQUIRES: system-darwin +# RUN: %lldb -o 'help add-dsym' | FileCheck %s --check-prefix=HELP +# HELP: Syntax: add-dsym <cmd-options> <filename> + # RUN: yaml2obj %S/Inputs/a.yaml -o %t.out # RUN: LLDB_APPLE_DSYMFORUUID_EXECUTABLE=%S/Inputs/dsymforuuid.sh %lldb %t.out -o 'add-dsym -u 41945CA4-5D9D-3CDE-82B4-37E4C09750B5' 2>&1 | FileCheck %s # CHECK: UUID information was not found `````````` </details> https://github.com/llvm/llvm-project/pull/98976 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
