================ @@ -40,7 +46,7 @@ lldb_private::Status WriteString(const std::string &to_write, /// the data on heap. class MinidumpFileBuilder { public: - MinidumpFileBuilder() = default; + MinidumpFileBuilder(lldb::FileUP&& core_file): m_core_file(std::move(core_file)) {}; ---------------- Jlalond wrote:
I agree with this. I also think it reduces the split responsibility with `ObjectfileMinidump` https://github.com/llvm/llvm-project/pull/95312 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits