llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-mc Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/94112.diff 3 Files Affected: - (modified) lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp (+1-1) - (modified) lldb/source/Utility/UriParser.cpp (+1-1) - (modified) llvm/lib/MC/MCExpr.cpp (+1-1) ``````````diff diff --git a/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp b/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp index 5f0684163328f..06c827c2543f4 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp @@ -152,7 +152,7 @@ static bool IsTrivialBasename(const llvm::StringRef &basename) { // because it is significantly more efficient then using the general purpose // regular expression library. size_t idx = 0; - if (basename.size() > 0 && basename[0] == '~') + if (basename.starts_with('~')) idx = 1; if (basename.size() <= idx) diff --git a/lldb/source/Utility/UriParser.cpp b/lldb/source/Utility/UriParser.cpp index 432b046d008b9..1932e11acb4c0 100644 --- a/lldb/source/Utility/UriParser.cpp +++ b/lldb/source/Utility/UriParser.cpp @@ -47,7 +47,7 @@ std::optional<URI> URI::Parse(llvm::StringRef uri) { ((path_pos != std::string::npos) ? path_pos : uri.size()) - host_pos); // Extract hostname - if (!host_port.empty() && host_port[0] == '[') { + if (host_port.starts_with('[')) { // hostname is enclosed with square brackets. pos = host_port.rfind(']'); if (pos == std::string::npos) diff --git a/llvm/lib/MC/MCExpr.cpp b/llvm/lib/MC/MCExpr.cpp index bbee2a64032a0..b065d03651c45 100644 --- a/llvm/lib/MC/MCExpr.cpp +++ b/llvm/lib/MC/MCExpr.cpp @@ -76,7 +76,7 @@ void MCExpr::print(raw_ostream &OS, const MCAsmInfo *MAI, bool InParens) const { // Parenthesize names that start with $ so that they don't look like // absolute names. bool UseParens = MAI && MAI->useParensForDollarSignNames() && !InParens && - !Sym.getName().empty() && Sym.getName()[0] == '$'; + Sym.getName().starts_with('$'); if (UseParens) { OS << '('; `````````` </details> https://github.com/llvm/llvm-project/pull/94112 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
