https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/91653
This should fix the various crashlog test failures on the bots:
```
lldb-shell ::
ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test
lldb-shell :: ScriptInterpreter/Python/Crashlog/interactive_crashlog_json.test
lldb-shell ::
ScriptInterpreter/Python/Crashlog/interactive_crashlog_legacy.test
lldb-shell ::
ScriptInterpreter/Python/Crashlog/last_exception_backtrace_crashlog.test
lldb-shell ::
ScriptInterpreter/Python/Crashlog/skipped_status_interactive_crashlog.test
```
When we create a target by using the command option, we don't set it in the
crashlog object which later on cause us to fail loading the images.
rdar://127832961
>From 3db7471fc507a1d5158d02f88402c846a8d4b4f3 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani <ism...@bennani.ma>
Date: Thu, 9 May 2024 13:42:55 -0700
Subject: [PATCH] [lldb/crashlog] Fix test failure when creating a target using
command options
This should fix the various crashlog test failures.
When we create a target by using the command option, we don't set it in
the crashlog object which later on cause us to fail loading the images.
rdar://127832961
Signed-off-by: Med Ismail Bennani <ism...@bennani.ma>
---
lldb/examples/python/crashlog.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/lldb/examples/python/crashlog.py b/lldb/examples/python/crashlog.py
index 2919b9c76e68..641b2e64d53b 100755
--- a/lldb/examples/python/crashlog.py
+++ b/lldb/examples/python/crashlog.py
@@ -1494,6 +1494,7 @@ def load_crashlog_in_scripted_process(debugger,
crashlog_path, options, result):
raise InteractiveCrashLogException(
"couldn't create target provided by the user (%s)" %
options.target_path
)
+ crashlog.target = target
# 2. If the user didn't provide a target, try to create a target using the
symbolicator
if not target or not target.IsValid():
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
