royitaqi wrote:

Hi @jimingham,

Thank you so much for the detailed explanation about the context and your 
thoughts. I appreciate it.

Good to know about the automated scripts and that you personally never used the 
existing transcript. It makes me feel that there are distinctively different 
use cases, and for the ones where the user know they won't need the transcript, 
they should be able to turn them off (and yes the text output can be large if 
someone opt to print e.g. statistics dump).

> As a matter of fact, that's a better design since then I can disable the 
> feature temporarily without having to mess up the settings I want when I do 
> do it.

This is also an interesting design aspect that I never thought about. This is 
good learning.

--

Overall I feel what you said makes sense. I will open a follow-up PR 
specifically for the settings, where we can discuss more (e.g. default on or 
off; should the setting turn off the existing transcript; should we add a 
`interpreter.save-session-format`; etc).

https://github.com/llvm/llvm-project/pull/90703
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to