https://github.com/AaronBallman commented:

I don't want this to be considered a comment which blocks the changes if others 
feel strongly in favor of them, but I'm not really convinced we should do this. 
The number of problems this patch will solve is approximately zero but the 
number of potential issues it will introduce is definitely nonzero. We've 
already seen one such problem come up during review and I expect there will be 
more, but also, this makes potential merge conflicts for downstreams (of the 
potentially frustrating variety because tools don't make line ending merge 
conflicts easy to spot).

It feels like a lot of churn for little benefit, even in the long term.

Note, the changes to clang-format-vs should likely all be reverted. .sln is a 
Microsoft Visual Studio solution file, as are many of the others. Also, it's a 
bit funny to have .bat files without CRLF endings given that they run on 
Windows. I have no idea whether Visual Studio will be happy with .natvis files 
having non-Windows line endings.

Realistically, each one of these files needs to be considered individually and 
that's a tall order for reviewers.

https://github.com/llvm/llvm-project/pull/86318
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to