https://github.com/feg208 created https://github.com/llvm/llvm-project/pull/89637
@jimingham I am wondering if you are ok removing this test? It caused failures in some of the build bots because the user time was less than a microsecond. Alternatively we can increase the number of loops or maybe I need some other approach? I had commented it out just to not impact others >From 21ae49be17c829281a0f9b1beef95712f0b19046 Mon Sep 17 00:00:00 2001 From: Fred Grim <fg...@apple.com> Date: Mon, 22 Apr 2024 10:17:14 -0700 Subject: [PATCH] I left some commented code in. This test doesn't run reliably in the different build bots --- lldb/unittests/Host/linux/HostTest.cpp | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/lldb/unittests/Host/linux/HostTest.cpp b/lldb/unittests/Host/linux/HostTest.cpp index 733909902474d7..5599e4349c8291 100644 --- a/lldb/unittests/Host/linux/HostTest.cpp +++ b/lldb/unittests/Host/linux/HostTest.cpp @@ -68,18 +68,4 @@ TEST_F(HostTest, GetProcessInfo) { EXPECT_TRUE(Info.GetArchitecture().IsValid()); EXPECT_EQ(HostInfo::GetArchitecture(HostInfo::eArchKindDefault), Info.GetArchitecture()); - // Test timings - /* - * This is flaky in the buildbots on all archs - ASSERT_TRUE(Host::GetProcessInfo(getpid(), Info)); - ProcessInstanceInfo::timespec user_time = Info.GetUserTime(); - static volatile unsigned u = 0; - for (unsigned i = 0; i < 10'000'000; i++) { - u = i; - } - ASSERT_TRUE(Host::GetProcessInfo(getpid(), Info)); - ProcessInstanceInfo::timespec next_user_time = Info.GetUserTime(); - ASSERT_TRUE(user_time.tv_sec < next_user_time.tv_sec || - user_time.tv_usec < next_user_time.tv_usec); - */ } _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits