jasonmolenda wrote:

It does occur to me that I'm going to need to only run this API test on targets 
which have a FixAddress method in their ABI, the base class own't do it.  Maybe 
it should have a base class impl that can be overridden, and use the Process 
masks if they are set.  (they're all initialized to 0 which is an impossible 
mask value (no address bits))  The base class impl would need to be overridden 
for different architectures, e.g. on AArch64 where TBI or MTE are used, in 
addition to clearing/setting the top byte, we need to use b55 to determine if 
the non-address bits are set to 1 or 0.  On armv7 the 0th bit can be used for 
metadata on TypeCode fixes, etc.

But still I'd expect the lldb-aarch64-ubuntu bot to have had a FixAddress impl 
in its ABI.  will check out when I build it up.

https://github.com/llvm/llvm-project/pull/83095
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to