https://github.com/jimingham requested changes to this pull request.
This looks good. You're being careful to do as narrow as possible a check for the buggy behavior. Handling this when the private StopInfo is great, that renders it a non-event in the higher level ShouldStop negotiations, which is exactly what we want. I had a couple trivial comments, and I don't think you should need the `friend class` statement. If you do need that for reasons I missed, we should probably make some API to get around that, StopInfoMachException really shouldn't need private access to the Thread class. https://github.com/llvm/llvm-project/pull/81573 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
