clayborg wrote:

> The discussions happening here are talking about 2 major things, how to do 
> the bookkeeping of the map that keeps track of progress reports and where to 
> do that bookkeeping. I think it makes sense to split up this work into 
> smaller patches as such:
> 
> 1. Since it's best to do the bookkeeping using the 
> `Debugger::eBroadcastBitProgressByCategory` bit, I'll add this bit to 
> `Debugger` and `SBDebugger` in its own patch.
> 2. Add a class to manage the map that holds progress reports.
> 3. Once that class and the bit are added, use it to perform operations on the 
> map of progress reports and use the new bit to actual broadcast operations.
> 
> I'll put up a patch to add the bit now and start work on parts 2 and 3. I'm 
> also going to close this PR since the work is now being split up.

Sounds great. Thanks for putting in the work on this!

Also, I do have the PR that adds settings and throttles progress events, do we 
still want that patch? I do believe that will improve our progress events and 
keep them from overwhelming clients. 

https://github.com/llvm/llvm-project/pull/81026
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to